Rebase - #8
Closed
lm-sousa wants to merge 6 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the FortranWeaver to support multiple weaver instances by explicitly passing the weaver instance through join point constructors, rather than relying on thread-local static access. Additionally, it updates JavaScript dependencies, improves GitHub Actions workflow branch resolution logic, and adds a new Copilot setup workflow.
Changes:
- Refactored Java joinpoint constructors to accept FortranWeaver parameter and removed static thread-local weaver access
- Updated JavaScript package dependencies to newer versions
- Improved GitHub Actions workflows with better branch resolution logic and added Copilot setup steps
- Fixed ESLint configuration structure by moving
tsconfigRootDirto correct location
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| GenericFortranJoinpoint.java | Updated constructor to accept FortranWeaver parameter |
| FProgram.java | Updated constructor to accept FortranWeaver parameter |
| AFortranWeaverJoinPoint.java | Added constructor accepting FortranWeaver and getWeaverEngine method override |
| FortranWeaver.java | Removed static getFortranWeaver method and updated getRootJp to pass weaver instance |
| FortranJoinpoints.java | Changed factory from FunctionClassMap to BiFunctionClassMap to support weaver parameter |
| package.json | Updated devDependencies to newer versions and bumped package version to 0.1.0 |
| eslint.config.js | Moved tsconfigRootDir to parserOptions and added __dirname definition |
| nightly.yml | Improved branch resolution with priority-based logic and removed unused environment variables |
| copilot-setup-steps.yml | New workflow file for Copilot integration with similar branch resolution logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lm-sousa
force-pushed
the
multi-weaver
branch
from
January 18, 2026 23:26
04db66b to
59d2eef
Compare
lm-sousa
force-pushed
the
multi-weaver
branch
from
September 7, 2026 18:25
fcc9871 to
4a5860c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Main's rebased code still used the removed static weaver accessors and 1-arg FortranJoinpoints.create. Thread the FortranWeaver instance through instead of restoring static/THREAD_LOCAL access: - FortranWeaver: make getFactory()/getContext() instance methods (getContext() referenced the removed getFortranWeaver() static) - AstFactory: take FortranWeaver as first parameter (same shape as the lara-4 branch), call weaver.getFactory() and 3-arg FortranJoinpoints.create(node, weaver, targetClass) - AFortranWeaverJoinPoint: thread getWeaverEngine() into the remaining main-era create() call sites and replace ::create method refs with weaver-capturing lambdas - joinpoints/F*: all concrete joinpoints from main now take (node, FortranWeaver) constructors with super(weaver) (or super(new FWrapper(node, weaver), weaver)); child-collection methods thread getWeaverEngine() into create() Also pin GitHub Actions to full commit SHAs in copilot-setup-steps.yml (Sonar S7637). Verified with: gradle -p FortranWeaver compileJava (BUILD SUCCESSFUL, JDK 17, lara-framework/specs-java-libs multi-weaver/master checkouts)
|
Open
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.